New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 127: Simple Proof-of-Reserves Transactions #756
Conversation
This needs a backward compatibility section (probably simply saying it's n/a). Also, @achow101 needs to ACK the modifications to BIP 174. |
You should add the new type to BIP 174's Appendix A. That should also include a link to the location in the new BIP descriibing it. |
35b85c0
to
1df16a9
Compare
Assigned BIP 127 |
I just realized it might be useful to have a way to deal with funds that are locked in a CLTV in the future. Are their opinions about this? I'm thinking of two approaches:
Both techniques would be quite straightforward to implement for verification. |
@luke-jr I updated the files to use the assigned number. Up to you if you merge it like this and allow me to update once I figured out a good way to deal with CLTV or if you want to wait for that in order to merge this. |
This can't be proven. The TXOs might get spent before time L. |
|
ACK BIP174 changes |
9c481e8
to
c1ef9e4
Compare
@luke-jr There is an error in the Travis that I don't understand. Seems to be related to the git history. I tried rebasing from latest master but that didn't work.. |
@luke-jr ping :) |
It's saying you need to update the README |
46fe591
to
7276e9a
Compare
@luke-jr fixed the README I don't currently have much time to work on this, but I think it's quite final apart from the CLTV issue. So can go in like this and I can amend with a fix for that if needed. |
(submitted to bitcoin-dev, awaiting approval)